Updated dependencies to allow usage of Kotlin 1.9, AGP 8+ and latest … #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunofvalente
force-pushed
the
feature/update-kotlin-to-1.9-and-compose
branch
from
b9f437d
to
10496d5
Compare
|
@nunofvalente Thanks for raising this PR. We will review it, and prioritise this tech stack upgrade soon for our future releases. |
|
Sorry to bother you @chintan-soni-cko, Any updates on this PR? We have problems with SDK after migrating to a new Kotlin, AGP and Compose versions on our project, will help a lot if there is an ETA on the merge for this PR. Thanks! |
|
Hey @PuhalschiAlexandru, we do plan to start making this upgrade next week once we finish some other priority work. I'll come back on here once we have more concrete timelines for releasing a new version of our Frames Android SDK. Thank you for your patience in the meantime! |
|
This PR is done as part of #245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Compose version
Issue
issue#208
Proposed changes
Frames SDK contains a lot of dependencies that are old and are an obstacle for companies to upgrade their codebases to use the latest dependencies as it is usually not supported by this SDK.
As we want to migrate to the newest Kotlin, AGP and Compose version we need Frames to be able to handle these versions as it was crashing our app. There is already an issue where people are not able to update their dependencies due to conflicts.
Migrated following dependecies:
The application now compiles with Java 17 instead of Java 8 as it is a requirement for AGP 8.1.0.
Test Steps
All the tests have passed. Didn't introduce new code, only changed what was not supported or deprecated.
I have tested the apps and they were working fine.
Checklist
Further comments
Most of the files were probably due to me optimising the imports.
MonochromeLauncherIcon lint issue is due to not having a monochromatic icon.
More information here: MonochromeLauncherIcon