Make pipeName
be WideCStringObj
so the data isn't deleted too early
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was brought up with
nimlsp
CI failing on windowsInvestigating it led me to this section where
pipeName
was becoming garbage by the time it got to line 186. Looking at the arc expansion I saw the internal data was getting deleted too earlyBy keeping a reference to the actual object instead of the pointer inside, it doesn't get destroyed too early