Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init option (initial animation) type #942

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

fteamkr
Copy link
Contributor

@fteamkr fteamkr commented Sep 19, 2024

Fix "Initial animation" option (init) type by document (https://www.chartjs.org/chartjs-plugin-annotation/latest/guide/configuration.html#initial-animation).

And init's return type might be Partial.

I created this PR not a issue, because it might be a simple fix. Thank you!

@stockiNail stockiNail added the types Typescript type changes label Sep 19, 2024
@stockiNail stockiNail added this to the 3.1.0 milestone Sep 19, 2024
@stockiNail
Copy link
Collaborator

@fteamkr thank you! Can you rebase the branch?

@stockiNail stockiNail merged commit a8dc07b into chartjs:master Sep 19, 2024
10 checks passed
@fteamkr fteamkr deleted the patch-1 branch September 19, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants