Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable drawTime option as integer to relate the annotation drawing to a specific dataset drawing #889

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

stockiNail
Copy link
Collaborator

@stockiNail stockiNail commented May 17, 2023

Fix #887

This PR enables the feature to draw an annotation before a specific dataset.
This is implemented setting drawTime option as integer which is representing the dataset index.
The annotation will draw always before the dataset specified by index. IF the index is not consistent (doesn't represent a valid dataset index) the annotation is not drawn.

drawTime

TODO

  • test cases
  • types
  • documentation

@stockiNail stockiNail marked this pull request as ready for review May 17, 2023 11:23
LeeLenaleee
LeeLenaleee previously approved these changes Aug 22, 2024
@stockiNail
Copy link
Collaborator Author

@LeeLenaleee I cannot merge because the checks are not available anymore and therefore the button is disable. I can switch to draft and again to ready for review in order to execute again the GHAs.

@stockiNail stockiNail merged commit a15dde6 into chartjs:master Sep 19, 2024
10 checks passed
@stockiNail stockiNail deleted the drawTimeXDataset branch September 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draw line annotation on top of first dataset but under second dataset
2 participants