Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example with Cannon's Matrix Multiplication #222

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add example with Cannon's Matrix Multiplication #222

wants to merge 7 commits into from
+177 −0

Conversation

ZwFink
Copy link
Contributor

@ZwFink ZwFink commented Dec 21, 2021

  • Adds an implementation of Cannon's Matrix Multiplication algorithm to examples
  • Showcases the following features:
    • Use of Numba to accelerate computation
    • 2-dimensional chare arrays
    • Channels
    • Reductions
    • Futures

@lgtm-com
Copy link

lgtm-com bot commented Dec 21, 2021

This pull request introduces 1 alert when merging 212e5dc into 3603cae - view on LGTM.com

new alerts:

  • 1 for Missing call to `__init__` during object initialization

minitu
minitu reviewed Dec 23, 2021
View reviewed changes
Copy link

@minitu minitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as an example, though it might be good to merge this in after optimizing the communication routines.

examples/cannon/cannon.py Show resolved Hide resolved
@ZwFink ZwFink requested review from adityapb, ritvikrao and mayantaylor and removed request for rbuch, matthiasdiener and evan-charmworks September 17, 2024 16:59
@ritvikrao
Copy link
Collaborator

ritvikrao commented Sep 17, 2024 •
edited
Loading

Can you add a readme to explain what this example does and how to run it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minitu minitu minitu left review comments

@adityapb adityapb Awaiting requested review from adityapb

@ritvikrao ritvikrao Awaiting requested review from ritvikrao

@mayantaylor mayantaylor Awaiting requested review from mayantaylor

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZwFink @ritvikrao @minitu