Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call super().__init__() in PoolScheduler __init__ #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nchristensen
Copy link
Contributor

@nchristensen nchristensen commented Oct 28, 2021

Subclasses of PoolScheduler can't work with the Pool because a missing attribute __local_free_head causes __addLocal__ to raise an AttributeError. Calling super().__init__() in the PoolScheduler __init__ method seems to fix this since the Chare class sets this attribute in its __init__().

Subclasses of `PoolScheduler` can't work with the Pool because a missing attribute `__local_free_head` causes `__addLocal__` to raise an AttributeError. Calling `super().__init__()` in the `PoolScheduler`  `__init__` method seems to fix this since the `Chare` class sets this attribute in its `__init__()`.
@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2021

This pull request fixes 1 alert when merging 84083a0 into 3603cae - view on LGTM.com

fixed alerts:

  • 1 for Missing call to `__init__` during object initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant