fix: use const colors to skip reading querying for the terminal bg color #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use AdaptiveColors and use regular colors instead. This makes the default styles _not_ use HasDarkBackground to determine the terminal background color. HasDarkBackground will query the terminal for the background color using `OSC 11` to determine which color to use in AdaptiveColor. For users who still want to use AdaptiveColors, they can supply their own custom styles. Fixes: #90
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 80.56% 80.16% -0.40%
==========================================
Files 11 11
Lines 746 731 -15
==========================================
- Hits 601 586 -15
Misses 131 131
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use AdaptiveColors and use regular colors instead. This makes the default styles not use HasDarkBackground to determine the terminal background color. HasDarkBackground will query the terminal for the background color using
OSC 11to determine which color to use in AdaptiveColor.For users who still want to use AdaptiveColors, they can supply their own custom styles.
Fixes: #90