Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stringify and universal cast-to-string deprecation #22068

Merged
merged 35 commits into from
Jul 27, 2023
Merged

stringify and universal cast-to-string deprecation #22068

merged 35 commits into from
Jul 27, 2023

Conversation

jeremiah-corrado
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado commented Apr 6, 2023 •
edited
Loading

As discussed here, stringify is being deprecated in favor of "%?".format. And the catch-all : string discussed here (which relied on stringify) is also being deprecated in favor of "%?".format.

Specifically, this PR makes the following changes:

  • deprecate stringify
  • deprecate the "catch-all" cast-to-string in ChapelIO
  • adds a cast-to-string specifically for FCF types s.t. they don't trigger the deprecation warning from the "catch-all" cast
  • fixes a bug in Formatted IO that caused the results of stringify(x) and "%?".format(x) to differ for a few types
  • modifies standard library, package modules, and tests to accommodate these changes
  • removes some unused regex functionality from writef as it was only applicable for readf

testing:

  • paratest
  • gasnet paratest
  • inspected docs

@jeremiah-corrado
deprecating stringify and cast-anything-to-string
2be5851 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
fixing bugs in stringify deprecation
3ea5072 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
more test corrections for stringify deprecation
63f53b9 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
fixing qio formatting of '%t', and test failures related to stringify…
4e41ef5 
… deprecation

Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
fix missing import
a426967 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
add deprecation tests for stringify and cast to string
afc88c4 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
more test corrections related to stringify deprecation and qio %t bug…
976b7ba 
… fixes

Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
Merge branch 'main' into test-stringify-deprecation
3148f10 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
address more test failures due to stringify deprecation
b8e147a 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
addressing enum:string related failures
387e4f8 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
removing unused code from stringcasts
5a02bfb 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
more test corrections due to stringify deprecation
16bb887 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
removing cast-to-string deprecation warning when casting FCF types to…
507b1ea 
… string

Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
cleaning up stringify deprecation
37bcc63 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado jeremiah-corrado mentioned this pull request Apr 17, 2023
Closed
@jeremiah-corrado
Merge branch 'main' into test-stringify-deprecation
ffc4ea6 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
Merge branch 'pcnt-q-format-specifier' into test-stringify-deprecation
9dfc493 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
change some instances of %t to %?
c77b6a2 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
fix merge conflict
7f88bb6 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
more %t -> %? updates in tests
6449f65 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
Merge branch 'pcnt-q-format-specifier' into test-stringify-deprecation
4030c86 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
Merge branch 'main' into test-stringify-deprecation
d656d27 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
Merge branch 'main' into test-stringify-deprecation
035433c 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
Merge branch 'main' into test-stringify-deprecation
7035480 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
fixing failed tests from stringify deprecation merge with %t -> %? ch…
ef2099e 
…ange

Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado jeremiah-corrado marked this pull request as ready for review July 21, 2023 20:55
benharsh
benharsh approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@benharsh benharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a couple of questions.

@jeremiah-corrado
address reviewer feedback
cdf0c24 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado jeremiah-corrado merged commit c4bfa69 into chapel-lang:main Jul 27, 2023
7 checks passed
@jeremiah-corrado jeremiah-corrado deleted the test-stringify-deprecation branch July 27, 2023 16:37
@jeremiah-corrado jeremiah-corrado mentioned this pull request Jul 28, 2023
Merged
1 task
jeremiah-corrado added a commit that referenced this pull request Jul 28, 2023
@jeremiah-corrado
Remove stringify call from Yaml serializer (#22833)
e557877 
Fix a test failure following
#22068 by replacing a call to
`stringify` with `"%?".format()` in the Yaml module.

- [x] yaml tests passing

[ reviewed by @mppf ] - Thanks!
@jeremiah-corrado jeremiah-corrado mentioned this pull request Jul 31, 2023
Merged
1 task
jeremiah-corrado added a commit that referenced this pull request Jul 31, 2023
@jeremiah-corrado
Remove extra string cast from map (#22844)
40fcbd4 
Removes the potential for a deprecation warning when accessing a map of
a non-primitive key type.

The `Map` module's `KeyNotFoundError` uses `string.format` to create
error message for keys of any type. However, one of map's `this`
assessors was casting the key to string when creating a
`KeyNotFoundError`, which can create a deprecation warning as of
#22068. This PR removes that
cast.

- [x] paratest

[ trivial - not reviewed ]
@arezaii arezaii mentioned this pull request Aug 7, 2023
Open
@jeremiah-corrado jeremiah-corrado mentioned this pull request Aug 9, 2023
Open
@lydia-duncan lydia-duncan mentioned this pull request Aug 21, 2023
Open
@jeremiah-corrado jeremiah-corrado mentioned this pull request Aug 21, 2023
Closed
@jeremiah-corrado jeremiah-corrado mentioned this pull request Sep 14, 2023
Merged
1 task
jeremiah-corrado added a commit that referenced this pull request Sep 14, 2023
@jeremiah-corrado
Deprecate array->string cast (#23380)
23e35cd 
Deprecate casting arrays to string. This is a continuation of the
deprecation of the universal string cast from [this
PR](#22068). See
#19893 for more context.

This deprecation recommends replacing:
```chapel
var s = myArray: string;
```
with:
```chapel
var s = "%?".format(myArray);
```

- [x] paratest

[ reviewed by @riftEmber ] - Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benharsh benharsh benharsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremiah-corrado @benharsh