Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we automatically infer CHPL_LLVM_GCC_INSTALL_DIR? #25925

Open
mppf opened this issue Sep 10, 2024 · 0 comments
Open

Should we automatically infer CHPL_LLVM_GCC_INSTALL_DIR? #25925

mppf opened this issue Sep 10, 2024 · 0 comments

Comments

@mppf
Copy link
Member

mppf commented Sep 10, 2024

PR # #25913 added CHPL_LLVM_GCC_INSTALL_DIR as an alternative to CHPL_LLVM_GCC_PREFIX. We do infer CHPL_LLVM_GCC_PREFIX if it is not set. Inferring CHPL_LLVM_GCC_PREFIX was added originally in #11615 and PR #18551 updated it to the current form.

CHPL_LLVM_GCC_PREFIX has the problem on some systems that it does not distinguish between different versions of gcc/g++ installed to the same path. For example, Ubuntu 24.04 allows multiple gcc installations that are all stored in the prefix /usr (the version is a suffix on commands in /usr/bin and stored in /usr/lib/gcc/x86_64-linux-gnu/<version>).

As a result, CHPL_LLVM_GCC_INSTALL_DIR is more robust. Should the inference we have, which is based on what gcc in the path uses, cause CHPL_LLVM_GCC_INSTALL_DIR to be set rather than CHPL_LLVM_GCC_PREFIX?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant