Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Linear Algebra isZero and isEye functions #22682

Closed
kwaters4 opened this issue Jul 6, 2023 · 2 comments
Closed

Feature Request: Linear Algebra isZero and isEye functions #22682

kwaters4 opened this issue Jul 6, 2023 · 2 comments

Comments

@kwaters4
Copy link

kwaters4 commented Jul 6, 2023

Summary of Problem

A couple of quality of life functions for the LinearAlgebra module would be a isZero or isEye functions. This functions would return a bool and be able to take a Matrix as an argument. Similar to the following functions:

proc isDiag -Return true if matrix is diagonal.

proc isHermitian - Return true if matrix is Hermitian

proc isSymmetric - Return true if matrix is symmetric

Maybe there is a quick way to do it already, but it was not obvious to me, outside of creating another identity or zero Matrix. Writing some loops would work as well. There could be some performance issues either approach. But in the end this would be a quality of life feature for users.

Not a blocking issue.

Iainmon added a commit that referenced this issue Jul 12, 2023
Relevant issue:
#22682
It was pointed out that we should have `isZero` and `isEye` methods in
the Linear Algebra module. This PR adds these.
Added two `isEye` and `isZero` to the linear algebra module. 

- [ ] Paratest
[reviewed by @jeremiah-corrado]
@bradcray
Copy link
Member

@Iainmon : I believe you added the requested routines in #22695 (thanks!). Could this issue be considered resolved by that PR, or do you consider there to be more to do here before closing the issue?

@Iainmon
Copy link
Contributor

Iainmon commented Jul 18, 2023

@bradcray , yes, this issue can be resolved. #22695

@Iainmon Iainmon closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants