Dependencies

[mgcooper]

What version of matplotlib and cartopy is installed into your working environment?

[mgcooper]

I know matplotlib was not required in prior versions but maybe that changed with the newer plotting utilities.

matplotlib is required just to read the configuration file because of the classes import which import the _visual module. Specifically the import of basins.py, see screen shot.

[changliao1025]

Within the read configuration function it calls the pybasin class, which imports the visualization functions. We will add a conditional import using the optional dependency.

[changliao1025]

@mgcooper
We will use optional dependency to address this.

from setuptools import setup

setup(
    name='mypackage',
    version='0.1',
    ...
    extras_require={
        'visualization': ['matplotlib']
    }
)

[mgcooper]

I think matlplotlib and Cartopy are required dependencies. If the visualization imports are removed from pybasin, they may be optional, but as far as I can tell they are required to run the software, unless the configuration files are also considered optional?

[changliao1025]

I added some conditional import, which means if the optional matplotlib and cartopy are not installed, the python module will disable the visualization capability.

The model already output geojson so user can easily visualize them using QGIS.

Besides, built-in visualization is only experimental and may cause crash. It is used for journals only right now.