From 780399e542df4501cfa768f462b5167c6a0a01dc Mon Sep 17 00:00:00 2001 From: mgcooper Date: Thu, 3 Aug 2023 07:50:18 -0700 Subject: [PATCH 1/2] chore: delete mac file system files --- .DS_Store | Bin 8196 -> 0 bytes docs/.DS_Store | Bin 8196 -> 0 bytes 2 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .DS_Store delete mode 100644 docs/.DS_Store diff --git a/.DS_Store b/.DS_Store deleted file mode 100644 index 82cbb27806813da3cddeefa0961fa7b135c5b770..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 8196 zcmeHMT}&KR6h3F6?fgg?uu{ObjM-Wt-6C6{khY}D0<~0{R(JU;$aZ#T3Zuge-I?8O zOEJVI`eJPTNqn%r*!U#TzG$L-@x|E0pZG&kjWIr`4?Y@=CO&!Y+<{OiFFvSg=O%N% zJNKNk_nz;5GdFh@05Dn5;{de)Akf87k*T^(VRm+{DUqP3oDeAta;2?hPp>GxIN z9WcQ$tV0Gu2G%mb9-ng1!GRpOE6?xQ8OwCNmX@0sDJ$Qwag!j5f>s{OpCfr(fe)Ven>v z%2iojS(&2c7JK+7ipZ-=DSoq@q9otbe^eUCDAh%p`SBUgbZmFX$h(9YrP8Hr`*V(c zB5yEzMybkaR<2-ap3!YtDf7JH4(A-JFm1ado^jS=Jtti!@Aded8AU0$#^VP0n?<9S zqTCUaevY{*APR3))a-~p6pQaWkmy_7T&Yx5-z!Nci51&3Pn$-5uw?4q)Trj>3|lwt z$>E~unpw+8+uF2I75P~d7q`~dZIK-=a12#%F?(_b2;Yd zY!qF2R}g*6PF0r2n58FgP^}As-`&_GOKF!)SqmKZG)q$YDOyg&r75t9?`@UjK}*XT zmZFP1tfNzshl`v_<_l;sIF@_^=g$7c+iW_5#x_p?*w zBZ4r>tlhe9=+Q(YUvHlUF`8%zmS2E6Xr_HD4dYQ<%m84Bma?HzpdaJ-Ev<|!_KDW*3Pc(<+WV3dMjn*Yln-&7tN9= z{Pnv=>=ZKyX0O`Q1Bn9?5q3RvwcZX0gL25iJ8+>J48#t!Tx?H#}_JdBTEKOQCh4dM`v;3$rf z{tRD#Poj$+7O_M+dF^D_x=MBZt5mnJQgy{t-nJZjlKPfZdaHYQ zcPB7V#*?UJ=l{O-zyIF}sfIa(41^4Mi&e|$nr|4pZ`OS0mL#XnP p?TVx9q(w21jtEJMky8ISoJG(Q5(P4(}%r2!A zLu{fi#@3(22kVQCPZI5mCfXNYj7|KBKP1%{T4gz2E(2Zq6(KU{}tF15^QkL>EI%rRo-i+1a(OM1r1TLZo;A8;taq9AY>q9;Qzn?o!P8N8=U*X8rC5LAp>_L1MK|}rHf%Az(s-l)j<_c0SH+N zzzel058yG;022W&3gn@5Pmw)f5Q;&Hfg+sjQRYsV2yjuL2nQ75fWgQZWGKi-r?@D0 z2TTYI>yUwvf%Ocq$EO5RkcJ#s1^N3&=^5Md{HCUx7%3{=RI*u;Wl1iTA4^WTvq@j~ zb6%I89b>;v>i$$ZXb-rqz1r5(LzX$4(zbTHj;~vendQNjVUo-Eu;m!;Y?qsJ43FO@ zDGYp|lvXo8ACEWhk40NrS{7o_`FL|Y9*efMwk|Bl(zg5K9et;#=g!YxSa|Xku`&$a z4p3IG(kq3_w7q<{_)HObd1aYjtu9kh@9I0I^ry6nJk9>ZjBmM)H)Li#!jx9#(Te*r zu5&VLGJ8rZ&**k0XY0P%Y1>Kbyy*>RTst@Icq6`f&SyQRJU8oi^Ujo}N*y>mG>3_a993E^jH*$}8?xlvBiv<6CDeGdnnI8UEC$?qy8J zu$;-^yyaPG+Z=H8X|p`?qbx6PtE%3j-mC6dF%^bLTAehKOIv4imOsbGsEw-1xIuF{ z?iy?qLwj42xn);WRmYg6J8M#HND}X^Z%~y1k4;$*9QQUV%D@w}rJ6@mU=!chtf+&w zo;GdGkVRNqyP^)~1(n*vLFb_kMIFhw)6=v>uN-4RcW0NXPOy>tb&de8#Fv$ zT~s|PNu$i#X&9zam#7ze&RLM_5>0^wB&dc)Iz&jq6bNL<~fOpN82pC?^Ej}(u>9gQ={%y>m?Gk7U5Q9kGfYT z>1sv7xk=e4kw~>o!rH2|$s}W~SXd7zha^&~RwAs26vpdQDc#)L&3|_|PNsUa4ui@1K<@FUPZ>dmu`DE6yU1yT|SJb*T zB>Z(dGEgKYUB&YM-i^Qi-;PTQ=NvK+GVnJUz~Y`{PZv3F^m1ppc9gEubg{zx76tMU ps(3n1$kTDc)jtfW9VJ&5lL&B8AoWoB*FOY==YM$qbLHLH)t}RS--G}F From 333bde4fa63b82072fe4eb126b5d31ff82d2064d Mon Sep 17 00:00:00 2001 From: mgcooper Date: Thu, 3 Aug 2023 09:09:36 -0700 Subject: [PATCH 2/2] docs: edit description of flow network categories in paper --- paper.bib | 17 +++++++++++++++++ paper.md | 12 ++++++------ 2 files changed, 23 insertions(+), 6 deletions(-) diff --git a/paper.bib b/paper.bib index efcdf63..f0944cc 100644 --- a/paper.bib +++ b/paper.bib @@ -40,6 +40,23 @@ @article{Liao:2023 abstract = {Abstract River networks are important features in surface hydrology. However, accurately representing river networks in spatially distributed hydrologic and Earth system models is often sensitive to the model’s spatial resolution. Specifically, river networks are often misrepresented because of the mismatch between the model’s spatial resolution and river network details, resulting in significant uncertainty in the projected flow direction. In this study, we developed a topological relationship-based river network representation method for spatially distributed hydrologic models. This novel method uses (1) graph theory algorithms to simplify real-world vector-based river networks and assist in mesh generation; and (2) a topological relationship-based method to reconstruct conceptual river networks. The main advantages of our method are that (1) it combines the strengths of vector-based and DEM raster-based river network extraction methods; and (2) it is mesh-independent and can be applied to both structured and unstructured meshes. This method paves a path for advanced terrain analysis and hydrologic modeling across different scales.} } +@article{mizukami_2016_GMD, + title = {{{mizuRoute}} Version 1: A River Network Routing Tool for a Continental Domain Water Resources Applications}, + shorttitle = {{{mizuRoute}} Version 1}, + author = {Mizukami, Naoki and Clark, Martyn P. and Sampson, Kevin and Nijssen, Bart and Mao, Yixin and McMillan, Hilary and Viger, Roland J. and Markstrom, Steve L. and Hay, Lauren E. and Woods, Ross and Arnold, Jeffrey R. and Brekke, Levi D.}, + year = {2016}, + month = jun, + journal = {Geoscientific Model Development}, + volume = {9}, + number = {6}, + pages = {2223--2238}, + publisher = {{Copernicus GmbH}}, + issn = {1991-959X}, + doi = {10.5194/gmd-9-2223-2016}, + urldate = {2023-08-03}, + langid = {english} +} + @article{Schwenk:2021, doi = {10.21105/joss.02952}, url = {https://doi.org/10.21105/joss.02952}, diff --git a/paper.md b/paper.md index e002a3c..1158183 100644 --- a/paper.md +++ b/paper.md @@ -32,11 +32,11 @@ River networks are crucial in hydrologic and Earth system models. Accurately rep # Statement of need For hydrologic modelers, river networks are a key input for hydrologic models. -While some hydrologic models accept vector-based river networks [@Schwenk:2021], others only accept mesh cell-based, which requires a generation method from the vector-based river network. +While some hydrologic models accept vector-based river networks [@mizukami_2016_GMD; @Schwenk:2021], others only accept mesh cell-based representations, or require a generation method from a vector-based river network. Currently, generating a mesh cell-based river network from a given vector-based river network and arbitrary computational mesh is a major challenge. Existing methods are typically limited to structured rectangular meshes, such as 30m x 30m cartesian grids for high-resolution watershed-scale modeling or 0.5 degree x 0.5 degree geographic grids for global climate modeling. In PyFlowline, we define structured meshes (e.g., lat-lon, raster files with projections, and hexagon) as those with fixed cell sizes and shapes and unstructured meshes as those with variable cell sizes and shapes. -Structured mesh-based methods use fixed cartesian or geographic cell sizes, which have several limitations: (1) they perform poorly at coarse resolution (>1km), and (2) they cannot be seamlessly coupled with other unstructured mesh-based hydrologic models such as oceanic models [@Engwirda:2021]. In contrast, unstructured meshes offer a flexible structure with variable grid-cell sizes and shapes. This flexibility makes them ideal for adapting to complex geometry such as river channels and coastlines. Besides, unstructured meshes provide the flexibility to couple different hydrologic models under a unified framework. +Structured mesh-based methods use fixed cartesian or geographic cell sizes, which have several limitations: (1) they cannot resolve fine-scale river networks at coarse cell resolutions (>1km), and (2) they cannot be seamlessly coupled with other unstructured mesh-based hydrologic models such as oceanic models [@Engwirda:2021]. In contrast, unstructured meshes offer a flexible structure with variable grid-cell sizes and shapes. This flexibility makes them ideal for adapting to complex geometry such as river channels and coastlines. Besides, unstructured meshes provide the flexibility to couple different hydrologic models under a unified framework. Thus, unstructured meshes are increasingly being adopted in hydrologic modeling. Although unstructured meshes offer these flexibilities, additional efforts are required to generate conceptual river networks that capture real-world river networks across different spatial scales. @@ -62,11 +62,11 @@ PyFlowline provides several key features, including # State of the field -Existing river network representation methods often fall into these three categories: +Existing river network representation methods often fall into three categories, each with associated strengths and weaknesses: -1. Vector-based, hydrologic models that use this method cannot couple river and land because there is no one-to-one mapping [@Schwenk:2021]; -2. High-resolution DEM-based, only supports structured rectangle grids (e.g., 30m x 30m ) at high spatial resolutions [@Esri:2011]; -3. Upscaling-based, only supports structured geographic grids (e.g., 0.5 degree x 0.5 degree) at coarse resolutions [@Wu:2012]. This method often cannot provide global coverage, including Greenland and the Antarctic. +1. Vector-based. Hydrologic models that use this method can represent fine-scale river networks, but cannot couple river and land without one-to-one mapping between river segments and land model cells [@Schwenk:2021]; +2. High-resolution DEM-based. Flow networks derived from structured rectangle-grid DEMs are widely available, but resolving fine-scale river networks requires grids with very high spatial resolution (e.g., 30m x 30m or finer) [@Esri:2011]; +3. Upscaling-based methods address the scale mismatch between coarse-resolution grids and fine-scale river networks, but only support structured geographic grids (e.g., 0.5 degree x 0.5 degree) at coarse resolutions [@Wu:2012]. This method often cannot provide global coverage, including Greenland and the Antarctic. PyFlowline is the only modeling software that provides these unique features: