Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bzlformat_lint_test fails on windows due to createprocess issue #447

Open
peakschris opened this issue Jun 29, 2024 · 0 comments
Open

bzlformat_lint_test fails on windows due to createprocess issue #447

peakschris opened this issue Jun 29, 2024 · 0 comments
Assignees

Comments

@peakschris
Copy link

peakschris commented Jun 29, 2024

The bzlformat_lint_test fails on windows as bazel cannot create a process invoking a shell script. The solution is to wrap the sh in a bat and bazel can launch this.

A bat wrapper rule is complex to write and maintain but is available in aspect_bazel_lib

The error is:

INFO: From Testing //tests/shlib_tests/lib_tests/messages_tests:bzlformat_lint_test:
==================== Test output for //tests/shlib_tests/lib_tests/messages_tests:bzlformat_lint_test:
ERROR(tools/test/windows/tw.cc:1302) ERROR: src/main/native/windows/process.cc(202): CreateProcessW("D:\udu\b\356umzpb\execroot\_main\bazel-out\x64_windows-fastbuild\bin\tests\shlib_tests\lib_tests\messages_tests\bzlformat_lint_test.sh"): %1 is not a valid Win32 application.
 (error: 193)
ERROR(tools/test/windows/tw.cc:1479) Failed to start test process (arg: D:\udu\b\356umzpb\execroot\_main\bazel-out\x64_windows-fastbuild\bin\tests\shlib_tests\lib_tests\messages_tests\bzlformat_lint_test.sh)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant