ENT-9402: Added policy to facilitate migration of ignore_interfaces.rx from inputdir to workdir #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsewi
approved these changes
Oct 31, 2023
cfe_internal/recommendations.cf
Outdated
Comment on lines
65
to
68
| (ignore_interfaces_in_workdir.ignore_interfaces_in_inputdir).!default:mpf_auto_migrate_ignore_interfaces_rx_to_workdir_reports_disabled:: | ||
| "NOTICE: ignore_interfaces.rx identical in $(const.dollar)(sys.workdir) and $(const.dollar)(sys.inputdir)." | ||
| if => strcmp( readfile( "$(sys.workdir)/ignore_interfaces.rx"), | ||
| readfile( "$(sys.inputdir)/ignore_interfaces.rx") ); | ||
|
|
||
| "NOTICE: ignore_interfaces.rx in $(const.dollar)(sys.workdir) and $(const.dollar)(sys.inputdir) but not identical." | ||
| if => not( strcmp( readfile( "$(sys.workdir)/ignore_interfaces.rx"), | ||
| readfile( "$(sys.inputdir)/ignore_interfaces.rx") ) ); |
There was a problem hiding this comment.
Is it? You can disable the noise if you like.
…utdir to workdir This change aims to increase awareness of the change in behavior for the location of the ignore_interfaces.rx file. It emits reports about the presence and status of the file. In order to further facilitate the migration, this policy will copy the file from inputdir to workdir if the class default:mpf_auto_migrate_ignore_interfaces_rx_to_workdir is defined and the file is present. Ticket: ENT-9402 Changelog: Title
nickanderson
force-pushed
the
ENT-9402/master
branch
from
6775d20
to
249f380
Compare
larsewi
approved these changes
Oct 31, 2023
This was referenced Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge together: