Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure bootstrap: Rewritten and improved #3248

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Secure bootstrap: Rewritten and improved #3248

merged 9 commits into from
Mar 14, 2024

Conversation

olehermanse
Copy link
Member

@olehermanse olehermanse commented Mar 14, 2024 •
edited
Loading

No description provided.

@olehermanse
Secure bootstrap: Switched to command blocks
607a853 
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Secure bootstrap: Removed unnecessary bullet point list formatting
047061b 
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Secure bootstrap: Reformatted to use one sentence per line style
7abe94c 
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Secure bootstrap: Added bootstrap command to the end
b40db17 
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Secure bootstrap: Rewrote first part about default configuration, int…
f7f1b83 
…roduction, disable automatic trust, etc.

Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Secure bootstrap: Added section on key location and generation
30d18af 
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Secure bootstrap: Rewrote section on key distribution
0f85a2b 
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Copy link
Member Author

@cf-bottom jenkins, please

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/551/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-551/output/_site/

@olehermanse
Copy link
Member Author

@cf-bottom jenkins, please

@cfengine cfengine deleted a comment from cf-bottom Mar 14, 2024
@olehermanse
Secure bootstrap: Small fixups and improvements
1d213d0 
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@cfengine cfengine deleted a comment from cf-bottom Mar 14, 2024
@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/554/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-554/output/_site/

nickanderson
nickanderson approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions/comments. but looks much better than it did previously.

getting-started/installation/secure-bootstrap.markdown Show resolved Hide resolved
getting-started/installation/secure-bootstrap.markdown Show resolved Hide resolved
getting-started/installation/secure-bootstrap.markdown Outdated Show resolved Hide resolved
getting-started/installation/secure-bootstrap.markdown Outdated Show resolved Hide resolved
@olehermanse
Secure bootstrap: Fixes based on Nick's review comments
80353b6 
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Copy link
Member Author

@cf-bottom Jenkins, please

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/555/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-555/output/_site/

@olehermanse olehermanse merged commit fcc11f5 into cfengine:master Mar 14, 2024
2 checks passed
@olehermanse olehermanse deleted the bootstrap branch March 14, 2024 20:24
@olehermanse
Copy link
Member Author

Cherry-pick: #3249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickanderson nickanderson nickanderson approved these changes

@larsewi larsewi Awaiting requested review from larsewi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olehermanse @cf-bottom @nickanderson