-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENT-11202: TOC scrolls with view #3213
Conversation
@cf-bottom jenkins please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/514/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-514/output/_site/ |
6055d2a
to
90c5c75
Compare
@cf-bottom jenkins please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/515/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-515/output/_site/ |
Ticket: ENT-11202 Changelog: None Signed-off-by: Mikita Pilinka <[email protected]>
90c5c75
to
32993a9
Compare
@cf-bottom jenkins blessRNG |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/516/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-516/output/_site/ |
@mineralsfree good work 👍 @olehermanse don't we need scroll for TOC? otherwise I cannot scroll TOC and select hidden elements, now I need to scroll the whole page |
@aleksandrychev we discussed this during meeting yesterday. Yes scrolling could be nice, but could also be annoying (end up scrolling the wrong thing). This change is definitely required, a big improvement, and should be merged like this, at least for now. |
cherry-picked in #3215 |
Ticket: ENT-11202
Changelog: None
Signed-off-by: Mikita Pilinka [email protected]