Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-11202: TOC scrolls with view #3213

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

mineralsfree
Copy link
Contributor

Ticket: ENT-11202
Changelog: None
Signed-off-by: Mikita Pilinka [email protected]

@mineralsfree mineralsfree added the WIP work in progress label Feb 13, 2024
@mineralsfree
Copy link
Contributor Author

@cf-bottom jenkins please

@mineralsfree
Copy link
Contributor Author

@cf-bottom jenkins please

Ticket: ENT-11202
Changelog: None
Signed-off-by: Mikita Pilinka <[email protected]>
@mineralsfree
Copy link
Contributor Author

@cf-bottom jenkins blessRNG

@mineralsfree
Copy link
Contributor Author

@olehermanse olehermanse removed the WIP work in progress label Feb 14, 2024
@aleksandrychev
Copy link
Contributor

@mineralsfree good work 👍

@olehermanse don't we need scroll for TOC? otherwise I cannot scroll TOC and select hidden elements, now I need to scroll the whole page

image

@olehermanse
Copy link
Member

@aleksandrychev we discussed this during meeting yesterday. Yes scrolling could be nice, but could also be annoying (end up scrolling the wrong thing). This change is definitely required, a big improvement, and should be merged like this, at least for now.

@olehermanse olehermanse merged commit f17a138 into cfengine:master Feb 15, 2024
2 checks passed
@mineralsfree
Copy link
Contributor Author

cherry-picked in #3215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants