Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-11149: Adjusted generator/build/main.sh to be more specific about package URLs #3169

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Jan 4, 2024

A package happened to have "deb" in it's commit hash so was included in the downloads list.

Ticket: ENT-11149
Changelog: none

together
https://github.com/cfengine/misc/pull/153
#3169

A package happened to have "deb" in it's commit hash so was included in the downloads list.

Ticket: ENT-11149
Changelog: none
@craigcomstock
Copy link
Contributor Author

what went wrong, we need to delete lines without ".deb" not just "deb".

Craigs-MacBook-Pro.local ? cat test | sed '/deb/!d;s/.*"\([^"]*\.deb\)".*/\1/'
<img src="/icons/compressed.gif" alt="[   ]" /> <a href="cfengine-masterfiles-3.18.7a.60aedeb35.tar.gz">cfengine-masterfiles-3.18.7a.60aedeb35.tar.gz</a>                2024-01-04 02:07  507K  
cfengine-nova-hub_3.18.7a.4e0d11b27~30805.ubuntu18_amd64.deb

with the fix

Craigs-MacBook-Pro.local ? cat test | sed '/\.deb/!d;s/.*"\([^"]*\.deb\)".*/\1/'
cfengine-nova-hub_3.18.7a.4e0d11b27~30805.ubuntu18_amd64.deb

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins please

Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

@olehermanse olehermanse merged commit d763331 into cfengine:master Jan 5, 2024
1 check passed
@craigcomstock
Copy link
Contributor Author

cherry picks
#3186
#3185

@craigcomstock craigcomstock deleted the ENT-11149/master branch January 10, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants