Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-10976: Consolidated and improved glossary #3141

Merged
merged 13 commits into from
Dec 5, 2023
Merged

ENT-10976: Consolidated and improved glossary #3141

merged 13 commits into from
Dec 5, 2023

Conversation

olehermanse
Copy link
Member

  • Moved all content from 2 glossary files into 1
  • Removed the duplicate glossary page
  • Glossary: Removed license notice
  • Glossary: Removed amber host, green host, yellow host
  • Glossary: Removed knowledge map, mission, copbl, constellation
  • Glossary: Standardized the formatting
  • Glossary: Re-alphabetized the content
  • Glossary: Removed several unexplained & unnecessary terms
  • Glossary: Removed duplicate entries
  • Glossary: Improved / polished a lot of the content

@olehermanse
Moved all content from 2 glossary files into 1
fb8f16d 
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Removed the duplicate glossary page
4d18780 
Ticket: ENT-10976
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Glossary: Removed license notice
f106e85 
This is the license for all of docs.

Ticket: ENT-10976
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Glossary: Removed amber host, green host, yellow host
72d899e 
These terms are not used any more.

Ticket: ENT-10976
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Glossary: Removed knowledge map, mission, copbl, constellation
db7e56e 
These older terms are no longer used.

Ticket: ENT-10976
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Glossary: Standardized the formatting
f278129 
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Glossary: Re-alphabetized the content
c6bccd8 
Now the content from the previous 2 glossary files are in a sane
order.

Commmits will follow to remove duplicates, empty entries, etc.

Ticket: ENT-10976
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Glossary: Removed several unexplained & unnecessary terms
34b0135 
Ticket: ENT-10976
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Glossary: Removed duplicate entries
87d38cc 
Ticket: ENT-10976
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse
Glossary: Improved / polished a lot of the content
2b74e9c 
Ticket: ENT-9076
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
nickanderson
nickanderson previously requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

overview/glossary.markdown Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Show resolved Hide resolved
overview/glossary.markdown Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
larsewi
larsewi approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from Grammarly

overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Show resolved Hide resolved
overview/glossary.markdown Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Show resolved Hide resolved
craigcomstock
craigcomstock reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for all that work! :)

overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
overview/glossary.markdown Outdated Show resolved Hide resolved
@olehermanse olehermanse dismissed nickanderson’s stale review December 5, 2023 14:23

Addressed all comments

@olehermanse olehermanse merged commit db9287d into cfengine:master Dec 5, 2023
1 check passed
@olehermanse olehermanse deleted the glossary branch December 5, 2023 14:27
vpodzime
vpodzime reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have squashed the first two commits because the first says things are being moved while it only adds content. But not a biggie.

overview/glossary.markdown Show resolved Hide resolved
overview/glossary.markdown Show resolved Hide resolved
@olehermanse olehermanse mentioned this pull request Dec 6, 2023
Merged
@olehermanse
Copy link
Member Author

Backport: #3145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime left review comments

@larsewi larsewi larsewi approved these changes

@nickanderson nickanderson Awaiting requested review from nickanderson

@craigcomstock craigcomstock Awaiting requested review from craigcomstock

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olehermanse @nickanderson @vpodzime @craigcomstock @larsewi