ENT-10267: docs navigation doesn't show user's location #3137
Conversation
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/435/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-435/output/_site/ |
mineralsfree
force-pushed
the
ENT-10267
branch
from
cea1b6e
to
8062479
Compare
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/436/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-436/output/_site/ |
mineralsfree
force-pushed
the
ENT-10267
branch
from
8062479
to
f4c2ae9
Compare
|
@cf-bottom jenkins, please |
1 similar comment
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/437/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-437/output/_site/ |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/438/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-438/output/_site/ |
mineralsfree
force-pushed
the
ENT-10267
branch
from
f4c2ae9
to
ad3b873
Compare
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/439/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-439/output/_site/ |
Ticket: ENT-10267 Changelog: None Signed-off-by: Mikita Pilinka <[email protected]>
mineralsfree
force-pushed
the
ENT-10267
branch
from
ad3b873
to
b42b713
Compare
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/440/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-440/output/_site/ |
mineralsfree
changed the title
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/458/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-458/output/_site/ |
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/463/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-463/output/_site/ |
|
@mineralsfree In this case, i think a few sentences in the commit message about when it was not working before and how it was fixed could be helpful. Also, seeing before and after screenshots in the PR would be nice. |
|
@mineralsfree I looked at the video and with your fix we are seeing the right navigation / context, but I also think we should add a highlight on the current article in the navigation. |
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/465/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-465/output/_site/ |
mineralsfree
force-pushed
the
ENT-10267
branch
from
2aa2ec6
to
bd306ab
Compare
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/466/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-466/output/_site/ |
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/469/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-469/output/_site/ |
mineralsfree
force-pushed
the
ENT-10267
branch
from
bd306ab
to
196341b
Compare
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/471/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-471/output/_site/ |
Ticket: ENT-10267 Changelog: None Signed-off-by: Mikita Pilinka <[email protected]>
mineralsfree
force-pushed
the
ENT-10267
branch
from
196341b
to
c73de06
Compare
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/473/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-473/output/_site/ |
|
@mineralsfree ah yeah, here I am checking commits for cherry picks for the release and found it a bit hard to find your cherry picks, but they are there and commited! 👍 I often make mention in the master PR of the cherry pick PRs, like: cherry pick only to 3.21.x as 3.18.x does not have the modified navigation there |
Thank you @craigcomstock, I'll do so next time |
Screen.Recording.2024-01-04.mov
Ticket: ENT-10267
Changelog: None