Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-10903: Added notes about lock purging #3111

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a few nits/questions.

Note: Promise locks are ignored when CFEngine is run with the `--no-lock` or
`-K` option, e.g. a common **manual** execution of the agent, `cf-agent -KI`
would not respect promises that are locked from a recent execution. Furthermore,
locks are purged in order to maintain the integrity and health of the underlying
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe clarify here that the locks are purged when the agent is run with --no-lock?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they purged when run with -K?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--no-lock/-K means that locks are ignored, but they are not purged. Or, more precisely, they are purge just like in any other agent run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, originally I said ignored, ill change it back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still says locks are purged in the sentence right above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are separate statements, I can bullet point them out and I can add a bit of text with the Furthermore ... indicating purging based on db utilization.

overview/directory-structure.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise.

Note: Promise locks are ignored when CFEngine is run with the `--no-lock` or
`-K` option, e.g. a common **manual** execution of the agent, `cf-agent -KI`
would not respect promises that are locked from a recent execution. Furthermore,
locks are purged in order to maintain the integrity and health of the underlying
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--no-lock/-K means that locks are ignored, but they are not purged. Or, more precisely, they are purge just like in any other agent run.

Ticket: ENT-10930
Changelog: None
@nickanderson nickanderson merged commit 526895b into cfengine:master Nov 21, 2023
1 check passed
@nickanderson nickanderson changed the title ENT-10930: Added notes about lock purging ENT-10903: Added notes about lock purging Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants