-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENT-10903: Added notes about lock purging #3111
Conversation
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/402/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-402/output/_site/ |
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/403/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-403/output/_site/ |
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/404/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-404/output/_site/ |
@cf-bottom jenkins, please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/405/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-405/output/_site/ |
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/406/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-406/output/_site/ |
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/407/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-407/output/_site/ |
@cf-bottom jenkins, please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/408/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-408/output/_site/ |
@cf-bottom jenkins, please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/409/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-409/output/_site/ |
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/410/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-410/output/_site/ |
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/411/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-411/output/_site/ |
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/412/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-412/output/_site/ |
9cb454e
to
47265b4
Compare
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/413/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-413/output/_site/ |
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/414/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-414/output/_site/ |
803f771
to
bc49c19
Compare
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/415/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-415/output/_site/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, a few nits/questions.
Note: Promise locks are ignored when CFEngine is run with the `--no-lock` or | ||
`-K` option, e.g. a common **manual** execution of the agent, `cf-agent -KI` | ||
would not respect promises that are locked from a recent execution. Furthermore, | ||
locks are purged in order to maintain the integrity and health of the underlying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe clarify here that the locks are purged when the agent is run with --no-lock
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are they purged when run with -K
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--no-lock/-K
means that locks are ignored, but they are not purged. Or, more precisely, they are purge just like in any other agent run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, originally I said ignored, ill change it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still says locks are purged in the sentence right above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are separate statements, I can bullet point them out and I can add a bit of text with the Furthermore ...
indicating purging based on db utilization.
bc49c19
to
c307749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me otherwise.
examples/tutorials/writing-and-serving-policy/controlling-frequency.markdown
Outdated
Show resolved
Hide resolved
Note: Promise locks are ignored when CFEngine is run with the `--no-lock` or | ||
`-K` option, e.g. a common **manual** execution of the agent, `cf-agent -KI` | ||
would not respect promises that are locked from a recent execution. Furthermore, | ||
locks are purged in order to maintain the integrity and health of the underlying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--no-lock/-K
means that locks are ignored, but they are not purged. Or, more precisely, they are purge just like in any other agent run.
Ticket: ENT-10930 Changelog: None
c307749
to
f5c0dc6
Compare
Quick link to preview pages that changed:
Ticket: ENT-10930
Changelog: None