Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-10250, ENT-10490: Added warning against using glob patterns on Windows #3088

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Sep 20, 2023

This reverts commit 83e52fb, reversing
changes made to 591f3f5.
@larsewi larsewi changed the title Added warning against using glob patterns on Windows ENT-10250, ENT-10490: Added warning against using glob patterns on Windows Sep 20, 2023
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one smaller suggestion.

reference/functions/findfiles_up.markdown Outdated Show resolved Hide resolved
reference/functions/findfiles.markdown Outdated Show resolved Hide resolved
We have found issues regarding the use of glob patterns on Windows (see
tickets below). However, we will not fix these issues before the next
minor release. Therefore, we added a warning in the documentation
advising to safeguard against any use on the Windows platforms.

Ticket: ENT-10250, ENT-10490
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>
Co-authored-by: Ole Herman Schumacher Elgesem <[email protected]>
@larsewi
Copy link
Contributor Author

larsewi commented Oct 31, 2023

Ping @nickanderson

@nickanderson nickanderson merged commit 10f2519 into cfengine:master Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants