CFE-2724: Removed incorrect claim that arglist attribute preserve spaces (3.18)
#3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed incorrect claim that the `arglist` attribute of the `commands` promise type, preserves spaces in the arguments. I believe it is meant to be that way, but it currently isn't. Thus we can revert this commit from master, once it is implemented in one of the next minor releases. For patch releases, we should keep the behaviour as is, since it may be relied upon. Ticket: CFE-2724 Changelog: None Signed-off-by: Lars Erik Wik <[email protected]> (cherry picked from commit 3c8881f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed incorrect claim that the
arglistattribute of thecommandspromise type, preserves spaces in the arguments. I believe it is meant to be that way, but it currently isn't. Thus we can revert this commit from master, once it is implemented in one of the next minor releases. For patch releases, we should keep the behaviour as is, since it may be relied upon.Back-ported from #3082