Only respect 'ifelapsed' if there is a previous promise evaluation #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the promise is being evaluated for the first time (no records in the locks LMDB), it doesn't make sense to check 'ifelapsed' for it.
olehermanse
approved these changes
Feb 23, 2021
It fixed an issue I was seeing in the logs which got me to the next issue which I didn't want to spend time on. The ticket number would be ENT-6200, I guess, that's the test I was debugging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the promise is being evaluated for the first time (no records
in the locks LMDB), it doesn't make sense to check 'ifelapsed'
for it.