ENT-10647: Fixed and improved postgresql server state handling in package scriptlets #1303
Conversation
…lets One typo fix. This was causing failure in ALL upgrades. Ouch. Changed wait time for server stop/start from 5 seconds to 60. Added cf_console to pg_upgrade failure tailing so it is visible in console. Changed condition to test for stopped/started to something that works with tighter restrictions. Using a select as root was failing due to lack of an account in postgresql at the moment we were checking: bare database without any further manipulation by setup scripts. Ticket: ENT-10647 Changelog: title
|
@cf-bottom jenkins please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9904/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9904/ |
|
When this is committed and cherry picks are merged, changelog entries are here: |
|
I confirmed that an upgrade on rhel-7 from 3.18.5 to this package (3.23.0a) worked well with no errors. Both with all services running before upgrade as well as with all services stopped. Also that in both cases, |
|
I would consider jenkins CI to be "green enough" as the only failure is something surfaced by the additional logging of why pg_upgrade failed. I logged https://northerntech.atlassian.net/browse/ENT-10710 to investigate why ubuntu 16 pg_upgrade fails and try to workaround the issue there specifically. |
One typo fix. This was causing failure in ALL upgrades. Ouch.
Changed wait time for server stop/start from 5 seconds to 60.
Added cf_console to pg_upgrade failure tailing so it is visible in console.
Changed condition to test for stopped/started to something that works with tighter restrictions.
Using a select as root was failing due to lack of an account in postgresql at the moment we
were checking: bare database without any further manipulation by setup scripts.
Ticket: ENT-10647
Changelog: title