-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification of rules for positioning comment and interval in cell methods strings #274
Comments
I agree with @martinjuckes that the conformance document has the intended interpretation. If that it is so, the text of the convention could be clarified as a defect issue. |
I think I prefer having the optional (and sometimes non-standard) parenthetical information coming at the "end of the phrase identifying the method"; breaking up the main elements of the method seems unnecessary. I would prefer, for example "mean where sea_ice (and in the immediate vicinity of polar bears)" to "mean (in the immediate vicinity of polar bears) where sea_ice". |
@taylor13 : apologies for the long silence on this issue. With the approach your approach, would you permit multiple comments, e.g. I can see the attraction of making a mis-placed comment a warning rather than an error, but we need to be sure that it does not introduce more complexity for software parsing the strings. |
I hadn't thought of that being necessary. On reflection, I don't really see a need to allow the parenthetical information to appear anywhere except at the end of any phrase specifying a method (but of course each method phrase could have parenthetical information, so multiple parenthetical statements could occur in cell_methods). Thus, in your example above you might have: I agree we should worry about difficulty parsing, but don't think anything discussed above would be too difficult. |
The discussion of this issue indicates that it should be addressed as a defect in the conformance document, so I am changing the label accordingly. |
Dear @martinjuckes Thanks for raising this issue in 2021. No objections were raised, and enough support was expressed to approve this proposal. It requires a PR to change the first sentence in Sect 7.3.2, for which you've already suggested wording. Are you able to prepare a PR? Best wishes and thanks Jonathan |
Following the agreement to make this change (in January), I have prepared PR 536 to implement a change along the lines of @martinjuckes's suggestion. The existing text is
and the new text is
I used the phrase "word list" for consistency with the conformance document, which says
If no concerns are raised, this change will be merged in three weeks from today, on 14th September. |
Looks good to me. Thanks, Jonathan. |
Me too. Thanks. |
I agree with the change |
No-one has raised concerns, and everyone who's spoken says they're happy, so I'll merge the change now. Thanks @martinjuckes for raising the issue and suggesting the solution four years ago! |
One of the contributors to the CMIP6 archive has contributed data with a
cell_methods
string of the form:area: time: mean (interval: 1 month) where sea_ice
. CF Checker 4.0.0 reports this as an errorERROR: (7.3): Invalid syntax for cell_methods attribute
.The relevant paragraph of the convention, the first in sub-section 7.3.2, states that "To indicate more precisely how the cell method was applied, extra information may be included in parentheses () after the identification of the method." The author of the data file is interpreting the reference to "after the identification of the method" as meaning directly after
mean
in thecell_methods
string. This is consistent with the usage of the word "method" throughout section 7.3.The conformance document, on the other hand, specifies that the the parentheses should come at the end of the phrase specifying the method, i.e.
area: time: mean where sea_ice (interval: 1 month)
, and the CF Checker, as we expect, follows the conformance document.My personal preference would be to follow the interpretation of the conformance document, provided this is consistent with the original intention of the sub-section in 7.3, but this would, I believe, require some clarification of the text, e.g. "To indicate more precisely how the cell method was applied, extra information may be included in parentheses () at the end of the phrase identifying the method."
The text was updated successfully, but these errors were encountered: