Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of path substitution #61

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Addition of path substitution #61

wants to merge 3 commits into from

Conversation

Khabi
Copy link

@Khabi Khabi commented Jul 8, 2019

In some cases when using reflex it makes sense to allow the path to the file changed to be used in the command.

A real life example is something like this:
-g 'pkg/auth/auth.proto' -- /go/bin/protoc -I pkg/ -I pkg/auth/ -I /go/src/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis/ -I /go/include/ --grpc-gateway_out=logtostderr=true:pkg/auth/ {}

In order for that command to run I need that path to the file pkg/auth/auth.proto and the path pkg/auth/. Since not all the .proto files live in the same path, I'd have to duplicate that command for every glob that isn't in /pkg/auth/

This allows you to use || by default as a placeholder for the path to the changed file. This lets you replace the above with the following and eliminate any duplication.

-g '*/*/*.proto' -- /go/bin/protoc -I pkg/ -I ||-I /go/src/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis/ -I /go/include/ --grpc-gateway_out=logtostderr=true:|| {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant