Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a time dimension in mask #264

Open
rafaqz opened this issue Oct 2, 2024 · 5 comments
Open

Allow a time dimension in mask #264

rafaqz opened this issue Oct 2, 2024 · 5 comments

Comments

@rafaqz
Copy link
Member

rafaqz commented Oct 2, 2024

We should to let the mask have a time dimension like aux data.

@nicolasmerino41 I've been using your amazing CheckMaskEdges fix to OutwardsDispersal, and it works perfectly for my boundaries (the sea). But I realized I have lakes appearing over time in my land cover! Have you had similar problems?

@nicolasmerino41
Copy link
Contributor

I don't think I have had this issue, although I don't really know what you mean. Do you mean that new masked cells appear forward in the simulation? That definitely hasn't happened to me :)

@rafaqz
Copy link
Member Author

rafaqz commented Oct 2, 2024

Yeahs my mask is changing over the simulation! I never had it either honestly, but your fix makes it very clear when it's happening

@nicolasmerino41
Copy link
Contributor

That's quite weird. I definitely don't see how my fix could be causing such weird behavior.

I assume with IgnoreMaskEdges() you don't get this problem?

@rafaqz
Copy link
Member Author

rafaqz commented Oct 2, 2024

No sorry your fix isn't causing it!

I mean I only noticed it with your fix running because you can clearly see where the fix isn't working. Because the area is not actually masked, it's just a death zone in the dispersal kernel.

Your fix just makes it very clear that we need to add a time dimension to the mask. (So CheckMaskEdges can do its job everywhere even if the mask changes with time)

@nicolasmerino41
Copy link
Contributor

Ok! I now see what you mean :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants