Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Fees #1685

Open
mustermeiszer opened this issue Jan 9, 2024 · 1 comment
Open

Transaction Fees #1685

mustermeiszer opened this issue Jan 9, 2024 · 1 comment
Labels
I8-enhancement An additional feature.

Comments

@mustermeiszer
Copy link
Collaborator

Description

Base is this RFC: https://gov.centrifuge.io/t/cp74-updating-transaction-fees-for-pools/5773

The idea is that governance should be able to control the fees that certain transactions are costing. In order to make this as easy as possible the following idea is proposes:

  • Include pallet orml-parameters (needs polkadot-v1.0.0 or higher)
    • The additional fees would be set by governance here and be retrieved by the logic in the SignedExtra
  • Extend SignedExtra either by
    • Wrapping pub struct ChargeTransactionPayment<T: Config>(#[codec(compact)] BalanceOf<T>); to have some logic that runs before the or after the one of that struct
    • Extend SignedExtra by a SignedExtension that has AdditionalSigned = () type (needed as we can not change SignedExtra due to wallet integrations breaking

This would allow

Requirements

  • NOT break existing wallet integrations
  • Show the additional fees as part of the fees logic that is provided by the runtime api pallet_transaction_payment_rpc_runtime_api::TransactionPaymentApi

Research/based on

How will this affect the code base

  • Increase CFG utility as stated by the governance proposal above

What are foreseen obstacles or hurdles to overcome?

None so far

@mustermeiszer mustermeiszer added the I8-enhancement An additional feature. label Jan 9, 2024
@mustermeiszer mustermeiszer added this to the Centrifuge 1027 milestone Jan 9, 2024
@mustermeiszer
Copy link
Collaborator Author

Although I am not convinced that orml-parameters is the best idea to be used.
We could still extend pallet-fees IMO and have a better event resolution.

@mustermeiszer mustermeiszer changed the title Transaction Fees [DRAFT] Transaction Fees Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I8-enhancement An additional feature.
Projects
None yet
Development

No branches or pull requests

1 participant