elliptic -> @noble/* #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 10bf4d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nicolasbrugneaux
force-pushed
the
elliptic-more-like-byelliptic
branch
from
97f268e
to
0e116b8
Compare
|
Running into issues with the sdk/wallets/wallet-aws-hsm tests. Kinda stuck on it atm |
|
probably worth a patch bump changeset stating that elipitical was removed |
nicolasbrugneaux
force-pushed
the
elliptic-more-like-byelliptic
branch
from
f3a5e80
to
1814ea2
Compare
|
Hi @kobigurk I'm kindly requesting you to have a look at this pull-request as your expertise would be greatly appreciated! |
aaronmgdr
reviewed
Jan 26, 2024
|
Asked for an owner (re point of contact with Kobi) on Slack. |
* test: add bls regression tests * refactor: more deps gone * refactor: types * refactor: getWordList * refactor: more deps gone * fix: utils * fix: keccak hash * fix: various buffer fixes * fix: force keccak to consider string as bytes * chore: update docs * fix: type * refactor: rlp -> @ethereumjs/rlp * refactor: eth-lib removal wip * refactor: eth-lib removal * chore: regenerate docs * fix: ensure no 0x-prefixed string is passed to hextobytes * fix: update snapshot * fix: ensure r,s,v are 0x prefixed * chore: regenerate docs * test: bls * test: some more signing-utils tests * chore: regenerate docs * chore: regenerate docs * fix: web3 resolution * fix: ledger SignMessage * chore: add note * chore: regenerate docs
nicolasbrugneaux
requested review from
aaronmgdr and
a team
and removed request for
aaronmgdr
shazarre
reviewed
Apr 2, 2024
shazarre
reviewed
Apr 2, 2024
shazarre
approved these changes
Apr 2, 2024
aaronmgdr
approved these changes
Apr 2, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ellipticis deprecated and old, we're replacing it with an audited and maintained pkg called@noble/curvesThe goal of the PR is also to replace most "handcrafted cryptography" by audited and maintained libraries.
[Closes #22]