Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

Extract latches into Celluloid itself? #23

Open
tarcieri opened this issue Sep 30, 2013 · 3 comments
Open

Extract latches into Celluloid itself? #23

tarcieri opened this issue Sep 30, 2013 · 3 comments

Comments

@tarcieri
Copy link
Member

See also celluloid/celluloid-io#89

The latches defined here:

https://github.com/celluloid/floss/blob/master/lib/floss/count_down_latch.rb
https://github.com/celluloid/floss/blob/master/lib/floss/latch.rb

...are potentially generally useful. Should we extract them into Celluloid?

@benlangfeld
Copy link
Member

This is a CountDownLatch implementation faithful to the Java API:
https://github.com/benlangfeld/countdownlatch

Something more complete like that would be nice :) It already allows
injection of a condition.

On 30 September 2013 20:07, Tony Arcieri [email protected] wrote:

See also celluloid/celluloid-io#89celluloid/celluloid-io#89

The latches defined here:

https://github.com/celluloid/floss/blob/master/lib/floss/count_down_latch.rb
https://github.com/celluloid/floss/blob/master/lib/floss/latch.rb

...are potentially generally useful. Should we extract them into Celluloid?


Reply to this email directly or view it on GitHubhttps://github.com//issues/23
.

@halorgium
Copy link
Contributor

@tarcieri I would be careful to make sure the implementations are thread-safe.
My intuition suggests that they are not right now.

@tarcieri
Copy link
Member Author

tarcieri commented Oct 1, 2013

@halorgium we should of course be careful to vet whatever implementations we want to merge into Celluloid proper

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants