Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(p2p): disable quic #3937

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix(p2p): disable quic #3937

merged 2 commits into from
Nov 14, 2024

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Nov 14, 2024

quic has been unstable lately as a transport. This PR disables quic and web transport support temporary until all related issues are resolved and tested.

@walldiss walldiss self-assigned this Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (2469e7a) to head (b134897).
Report is 381 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/p2p/host.go 61.53% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3937      +/-   ##
==========================================
+ Coverage   44.83%   45.29%   +0.45%     
==========================================
  Files         265      307      +42     
  Lines       14620    21846    +7226     
==========================================
+ Hits         6555     9895    +3340     
- Misses       7313    10878    +3565     
- Partials      752     1073     +321     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cristaloleg cristaloleg added the kind:fix Attached to bug-fixing PRs label Nov 14, 2024
@walldiss walldiss marked this pull request as ready for review November 14, 2024 09:47
renaynay
renaynay previously approved these changes Nov 14, 2024
@walldiss walldiss enabled auto-merge (squash) November 14, 2024 11:02
@walldiss walldiss merged commit e6dbb54 into celestiaorg:main Nov 14, 2024
28 checks passed
@Wondertan Wondertan deleted the disable-quic branch November 14, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants