-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(p2p): disable quic #3937
Merged
Merged
fix(p2p): disable quic #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3937 +/- ##
==========================================
+ Coverage 44.83% 45.29% +0.45%
==========================================
Files 265 307 +42
Lines 14620 21846 +7226
==========================================
+ Hits 6555 9895 +3340
- Misses 7313 10878 +3565
- Partials 752 1073 +321 ☔ View full report in Codecov by Sentry. |
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
cristaloleg
as code owners
November 14, 2024 09:47
cristaloleg
reviewed
Nov 14, 2024
cristaloleg
reviewed
Nov 14, 2024
renaynay
previously approved these changes
Nov 14, 2024
walldiss
force-pushed
the
disable-quic
branch
from
November 14, 2024 10:56
52a6916
to
40bea0e
Compare
cristaloleg
approved these changes
Nov 14, 2024
Wondertan
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quic has been unstable lately as a transport. This PR disables quic and web transport support temporary until all related issues are resolved and tested.