Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove blob size check #3934

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Nov 12, 2024

Closes #3356

Removes an unnecessary conditional because of this comment.

@rootulp rootulp self-assigned this Nov 12, 2024
@github-actions github-actions bot added the external Issues created by non node team members label Nov 12, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.24%. Comparing base (2469e7a) to head (c802e87).
Report is 378 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3934      +/-   ##
==========================================
+ Coverage   44.83%   45.24%   +0.41%     
==========================================
  Files         265      307      +42     
  Lines       14620    21831    +7211     
==========================================
+ Hits         6555     9878    +3323     
- Misses       7313    10884    +3571     
- Partials      752     1069     +317     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgonkivs vgonkivs added area:blob kind:fix Attached to bug-fixing PRs labels Nov 13, 2024
@renaynay renaynay enabled auto-merge (squash) November 13, 2024 11:57
@renaynay renaynay merged commit fa01196 into celestiaorg:main Nov 13, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob external Issues created by non node team members kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob.NewBlob will reject > 2 MB blobs even if the square size is increased
5 participants