Some inconsistencies with Share.GetRange RPC

[zvolin]

Celestia Node version

0.15

OS

Install tools

No response

Others

No response

Steps to reproduce it

Hey, when integrating Share.GetRange API I found some potential inconsistencies / inefficiencies:

• the naming conventions are mixed, the first layer is named using PascalCase but everything inside is snake_case
• row roots in RowProof are serialized as hex, where everywhere else they are base64
• the ShareProof uses celestia-core NMTProof proto, where everything else uses nmt proof proto
• the shares are returned twice, in the Shares field and in the Proof.data field. This doubles the amount of information transmitted
• the proof verification is completely disjoint from the shares itself. Proof is self contained thus user needs to remember to additionally compare returned Shares with the ones proven in proof

Expected result

some of those should probably be split into separate issues, but wanted to check if you aware of those and consider them being actual issues

Actual result

Relevant log output

No response

Is the node "stuck"? Has it stopped syncing?

No response

Notes

No response