Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Local iterations #5

Merged
merged 1 commit into from
Jan 21, 2024
Merged

feat: Local iterations #5

merged 1 commit into from
Jan 21, 2024

Conversation

dnys1
Copy link
Member

@dnys1 dnys1 commented Jan 21, 2024

Initial release of the Celest CLI with a full local iterations experience.

Copy link
Member Author

dnys1 commented Jan 21, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

## Running the app

- Go to the hello directory, and run `flutter pub get`
- Go to the `celest` directory inside the hello example app and run `dart pub get`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering here on why you need to run dart pub get if the CLI takes care of installing dependencies for you?

@@ -0,0 +1,8 @@
# hello

A new Flutter project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new Flutter project.

@@ -0,0 +1,8 @@
# hello
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter project


## Running the app

- Go to the hello directory, and run `flutter pub get`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go to the hello directory in your console, and run flutter pub get.

import 'package:celest/celest.dart';

const project = Project(
name: 'hello',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the name of the project and the app should be something like "my_flutter_project". Hello is confusing me. That should change both on the frontend and backend.

Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnys1 dnys1 force-pushed the feat/local-iterations branch 3 times, most recently from 190b684 to 75c503f Compare January 21, 2024 22:58
Initial release of the Celest CLI with a full local iterations experience.
@dnys1 dnys1 merged commit ab9ad5f into main Jan 21, 2024
4 checks passed
@dnys1 dnys1 deleted the feat/local-iterations branch January 21, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants