return in finally can swallow exceptions

[iritkatriel]

In three places in your codebase, you have a return statement in a finally block, which would swallow any in-flight exception:

billiard/billiard/connection.py

Line 349 in 366ac5f

return f

billiard/billiard/connection.py

Line 351 in 366ac5f

return self._get_more_data(ov, maxsize)

billiard/billiard/pool.py

Line 1856 in 366ac5f

return self._send_ack(

This means that if a BaseException (such as KeyboardInterrupt) is raised from the try body, or any exception is raised from an except: clause, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.