Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor assembler #55

Merged
merged 33 commits into from
Feb 16, 2024
Merged

Refactor assembler #55

merged 33 commits into from
Feb 16, 2024

Conversation

cjvth
Copy link
Member

@cjvth cjvth commented Jan 30, 2024 •
edited
Loading

Reorganize code of cocas into possibly independent modules. Make it easier to localize and fix bugs. Improve some UI features. Fix linter warnings.

  • Separate assembler, object files import/export, linker and common code into modules
  • Move more functions into separate files
  • Build import hierarchy without circular imports
  • Raise different exceptions in different modules
  • Catch errors in main better
  • Print colored errors like before Make assembler modular #1
  • Make file paths in errors clickable in VS Code
  • Rewrite CodeSegmentsInterface and TargetInstructionsInterface to abstract classes
  • Make function and class naming more consistent
  • Fix mess with str and pathlib.Path
  • Try to fix warnings about wrong argument types
  • Ensure that cocas works on older versions of Python (result: cocas works starting with Python 3.9)
  • Write documentation for importable functions and classes

Fixes:

  • Correctly check maximum image size for CdM-8 and for too big individual sections

@cjvth
Update poetry.lock
a15a913
@cjvth
[cocas] Move source files to modules inside cocas
631a727
@cjvth
Add files generated by make to .gitignore
548e682
@cjvth
[cocas] Reorganize code of object_module
abca58e
@cjvth
[cocas] Fix imports inside targets
e8bf7af 
Wrap potential circular imports in `if TYPE_CHECKING:`. It used to work because of importlib
@cjvth
[cocas] Move target parameters for object files into module
e7e80a1
@cjvth
[cocas] Remove passing unused target_params to linker and delete files
3836673
@cjvth
[cocas] Move cocas/targets to cocas/assembler/targets
15003ad
@cjvth
[cocas] Move importing target module inside assembler
ae79f6f
@cjvth
[cocas] Move stages of assembling into module
02bb1a2
@cjvth
[cocas] Move reading and processing multiple files to modules
1820690
@cjvth
[cocas] Fix circular import in cdm8e
5fbce37
@cjvth
[cocas] Move code of opening and writing to files
ea16c44
@cjvth cjvth added the enhancement New feature or request label Jan 30, 2024
@cjvth
[cocas] Remove CodeSegmentsInterface, addI prefix to its members
6015f29 
Its (target-specific) derivatives and their members were never used, except for target_instructions of that same target
@cjvth
[cocas] Change code segments to be based on abstract classes and prop…
ffc2279 
…erties
@cjvth
[cocas] Change target instructions interface to be with abstract methods
b7234a7
@cjvth
[cocas] Make using str and Path consistent
6f3815c 
Also use use absolute paths and as_posix() in most places
@cjvth
[cocas] Fix remaining warnings in cocas
869ccae
@cjvth
[cocas] Move exception class declarations into modules
d9defbc
@cjvth
[cocas] Rename exceptions
a9bc14c
@cjvth
[cocas] Properly handle exceptions in main
50d63d1
@cjvth
[cocas] Make imports better and fix code style
d6718d0
@cjvth
[cocas] Add docstrings for all importable functions and modules
d4f1b4e
@cjvth
[cocas] Add docstrings for fields of public structures
c326a69
@cjvth
[cocas] Make cocas work on Python 3.9
c1c392d
@cjvth
[cocas] Fix wrong file path in object file
9e62226
@cjvth
[cocas] Fix image size check and add info for targets in linker
e264347
@cjvth cjvth marked this pull request as ready for review February 16, 2024 20:23
@Intelix8996 Intelix8996 added this to the Release 0.2.0 milestone Feb 16, 2024
@Intelix8996 Intelix8996 merged commit 19ab6f7 into master Feb 16, 2024
2 checks passed
@Intelix8996 Intelix8996 deleted the assembler-big-refactor branch February 16, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Intelix8996 Intelix8996 Intelix8996 approved these changes

Assignees

@cjvth cjvth

Labels
enhancement New feature or request
Projects
Core Team Task Board
Status: ✅ Done
Milestone
Release 0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cjvth @Intelix8996