Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enableServiceLinks in Pod Specs. #2179

Open
1 of 2 tasks
HamishWHC opened this issue Mar 13, 2024 · 1 comment
Open
1 of 2 tasks

Support enableServiceLinks in Pod Specs. #2179

HamishWHC opened this issue Mar 13, 2024 · 1 comment
Labels
@component/cdk8s-plus Issue related to cdk8s-plus effort/small 1 day tops feature-request New/Enhanced functionality wanted good-first-issue Good for newcomers priority/p2 Dependent on community feedback. PR's are welcome :)

Comments

@HamishWHC
Copy link

Description of the feature or enhancement:

Pods and workloads that define pods (e.g. Deployments, StatefulSets, etc) should have the enableServiceLinks property that defines whether the pod has service discovery environment variables defined.

Use Case:

I need to be able to disable this option across many workloads, and would prefer to have a better way than applying JSON patches.

Proposed Solution:

Addition of enableServiceLinks: boolean to AbstractPodProps. I haven't played with the CDK8s-plus internels yet so there may also be runtime manipulation needed.

Other:

Documentation: https://kubernetes.io/docs/tutorials/services/connect-applications-service/#accessing-the-service

Pod Spec Reference: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.29/#pod-v1-core

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@HamishWHC HamishWHC added feature-request New/Enhanced functionality wanted needs-triage Priority and effort undetermined yet labels Mar 13, 2024
@iliapolo iliapolo added good-first-issue Good for newcomers priority/p2 Dependent on community feedback. PR's are welcome :) effort/small 1 day tops and removed needs-triage Priority and effort undetermined yet labels Jun 2, 2024
@iliapolo
Copy link
Member

iliapolo commented Jun 2, 2024

@HamishWHC This is a good first issue for contribution, if you feel up for it :)

@iliapolo iliapolo added the @component/cdk8s-plus Issue related to cdk8s-plus label Sep 20, 2024
@iliapolo iliapolo transferred this issue from cdk8s-team/cdk8s-plus Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@component/cdk8s-plus Issue related to cdk8s-plus effort/small 1 day tops feature-request New/Enhanced functionality wanted good-first-issue Good for newcomers priority/p2 Dependent on community feedback. PR's are welcome :)
Projects
None yet
Development

No branches or pull requests

2 participants