Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add className to ExposeDeploymentViaIngressOptions #2178

Open
1 of 2 tasks
chneau opened this issue Mar 15, 2024 · 0 comments
Open
1 of 2 tasks

Add className to ExposeDeploymentViaIngressOptions #2178

chneau opened this issue Mar 15, 2024 · 0 comments
Labels
@component/cdk8s-plus Issue related to cdk8s-plus effort/small 1 day tops feature-request New/Enhanced functionality wanted priority/p2 Dependent on community feedback. PR's are welcome :)

Comments

@chneau
Copy link

chneau commented Mar 15, 2024

Description of the feature or enhancement:

Being able to set className on deployment.exposeViaIngress("/")

Use Case:

Consistency between a constructor and an "exposeXXX".
Make code shorter to write and more meaningful by deleting boilerplate and repetitive code.

Proposed Solution:

deployment.exposeViaIngress("/",{ className: "nginx" })

Other:

How I fix at the moment:

	const service = deployment.exposeViaService();
	const ingress = new Ingress(chart, "ingress", { className: "nginx" });
	ingress.addRules({
		backend: IngressBackend.fromService(service),
		host: host,
		path: "/",
	});
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@chneau chneau added feature-request New/Enhanced functionality wanted needs-triage Priority and effort undetermined yet labels Mar 15, 2024
@iliapolo iliapolo added priority/p2 Dependent on community feedback. PR's are welcome :) effort/small 1 day tops and removed needs-triage Priority and effort undetermined yet labels Jun 2, 2024
@iliapolo iliapolo added the @component/cdk8s-plus Issue related to cdk8s-plus label Sep 20, 2024
@iliapolo iliapolo transferred this issue from cdk8s-team/cdk8s-plus Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@component/cdk8s-plus Issue related to cdk8s-plus effort/small 1 day tops feature-request New/Enhanced functionality wanted priority/p2 Dependent on community feedback. PR's are welcome :)
Projects
None yet
Development

No branches or pull requests

2 participants