Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has ignoreUndocumented's default value changed? #965

Open
zelanter opened this issue Sep 6, 2024 · 3 comments
Open

Has ignoreUndocumented's default value changed? #965

zelanter opened this issue Sep 6, 2024 · 3 comments

Comments

@zelanter
Copy link

zelanter commented Sep 6, 2024

Hi,

I'm troubleshooting some issues currently, and I found that if I don't set ignoreUndocumented to true, my OPTIONS requests get blocked and return 405.

However, I have projects using older versions of the library that did not require that setting, so I was wondering if maybe along the way the default value for ignoreUndocumented changed from true to false.

If not then something else in my configuration is causing this behavior I suppose.

@zelanter
Copy link
Author

zelanter commented Sep 6, 2024

It seems issue was something else, the order of my middlewares was wrong, causing cors middleware to run after validation.

@cdimascio
Copy link
Owner

Glad you sorted it. Sounds like this can be closed?

@zelanter
Copy link
Author

zelanter commented Sep 6, 2024

Glad you sorted it. Sounds like this can be closed?

As far as I am concerned, yes, since it's a side effect of bad configuration, but I wonder if it's normal still that this library would attempt to validate an OPTIONS request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants