-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FullCBFWriter: repair the panel shuffling bug (#745) #752
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
+ Coverage 41.54% 41.56% +0.02%
==========================================
Files 189 189
Lines 17060 17066 +6
Branches 3271 3273 +2
==========================================
+ Hits 7088 7094 +6
Misses 9318 9318
Partials 654 654 |
Oh I see, great find. Ok, I'd like to test this a bit on my side. Will be quick about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested it on the JF16M Zenodo deposition using dxtbx.image_average and got the same result (binary identical using diff). Thanks!
@phyy-nx Thank you very much for your review. |
I squashed the commit down on main :) |
This fixes the bug reported in #745, which also contains test datasets.