Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 Compatibility #725

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Python 3.12 Compatibility #725

merged 7 commits into from
Apr 23, 2024

Conversation

ndevenish
Copy link
Collaborator

@ndevenish ndevenish commented Apr 19, 2024

  • Update registry for dual 3.9/3.10 importlib.metadata API (deprecated and removed in 3.12)
  • Update CMake infrastructure by integrating changes from DIALS

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.81%. Comparing base (884de37) to head (990b49b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   42.22%   41.81%   -0.42%     
==========================================
  Files         187      187              
  Lines       16802    16806       +4     
  Branches     3207     3208       +1     
==========================================
- Hits         7095     7027      -68     
- Misses       9061     9133      +72     
  Partials      646      646              

@ndevenish ndevenish marked this pull request as ready for review April 23, 2024 08:14
@ndevenish ndevenish changed the title Python 3.12: Enable testing and changes for compatibility Python 3.12 Compatibility Apr 23, 2024
@ndevenish ndevenish merged commit e0c47b6 into main Apr 23, 2024
21 checks passed
@ndevenish ndevenish deleted the python3.12 branch April 23, 2024 08:17
toastisme pushed a commit to toastisme/dxtbx that referenced this pull request Jul 18, 2024
- Update CI configuration
- Update registry for dual 3.9/3.10 importlib.metadata API (deprecated and removed in 3.12)
- Update CMake infrastructure by integrating changes from DIALS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant