글 상세 페이지(API 추가 전) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XionWCFM
reviewed
Apr 7, 2024
| @@ -0,0 +1,18 @@ | |||
| export type ProfileHeaderProps = { | |||
There was a problem hiding this comment.
🤖 파일명 컨벤션(아님) 따라서 question-detail-type.ts 에서 question-detail.type.ts 로 바꾸면 더 좋을것같아요
| @@ -0,0 +1,67 @@ | |||
| import styled, { css } from "styled-components"; | |||
There was a problem hiding this comment.
이부분 type error로 인해 build error 발생하네요
| export const QuestionDetailPage = () => { | ||
| return( | ||
| <> | ||
| <QuestionDetailContainer> |
There was a problem hiding this comment.
탭이 네칸으로 보입니다 프리티어가 적용안된것같아용
src/shared/icons/main/View.tsx
Outdated
| @@ -1,6 +1,6 @@ | |||
| import { IconProps } from "../Icons.type"; | |||
src/shared/route/index.ts
Outdated
| @@ -1 +1 @@ | |||
| export * from "./route"; | |||
| export * from "./route"; | |||
There was a problem hiding this comment.
공백 변경사항은 다음엔 반영 안해도 좋을 것 같읍니다!
Yongveloper
reviewed
Apr 7, 2024
| @@ -0,0 +1,67 @@ | |||
| import styled, { css } from "styled-components"; | |||
There was a problem hiding this comment.
css 부분 안 하는 부분 지워주셔야 lint 통과 될 거 같아요~!
Comment on lines
19
to
31
| const QuestionCodeType = styled.p` | ||
| color: ${({theme}) => theme.colors.main}; | ||
| font-size: ${({theme}) => theme.fontSize.subtitle2}; | ||
| ` | ||
| const QuestionGitLinkBtn = styled.a` | ||
| cursor: pointer; | ||
| line-height: 30px; | ||
| font-size: ${({theme}) => theme.fontSize.button}; | ||
| border: none; | ||
| border-radius: 10px; | ||
| padding: 0 18px; | ||
| background-color: ${({theme}) => theme.colors.secondary}; | ||
| ` |
There was a problem hiding this comment.
prettier 적용이 안 된 것 같아요!
prettier 익스텐션 설치 확인 한번 해주세요~
Sang-minKIM
previously requested changes
Apr 7, 2024
src/entities/question-detail-page/model/question-detail-type.ts
Outdated
Show resolved
Hide resolved
src/entities/question-detail-page/ui/question-detail-profile.tsx
Outdated
Show resolved
Hide resolved
src/entities/question-detail-page/ui/question-detail-profile.tsx
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for calm-gumdrop-cdbfa2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tubular-smakager-c0ad14 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API 추가 전 껍데기 텍스트만 넣어놓은 상태