Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching too many folder collaborations #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trysmr
Copy link

@trysmr trysmr commented May 13, 2023

Hi,

The List folder collaborations API does not seem to support offset and limit.
https://developer.box.com/reference/get-folders-id-collaborations/

If we specify an offset and limit smaller than total_count for the folder_collaborations, the loop in the get_all_with_pagination will increase the number of collaborators.

We should use the the get method in the folder_collaborations.

Thank you!

@xhocquet
Copy link
Collaborator

Hey @trysmr , thanks for the contribution! Your change makes sense based on the info provided. I'll take a look and see if we can get this merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants