Add support for copying a specific version of a file #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkash
changed the title
xhocquet
reviewed
Dec 13, 2022
There was a problem hiding this comment.
Hey @dmkash , thanks for the contribution! This change seems safe enough, but to merge I would love to see the param used and verified in the smoke tests in https://github.com/cburnette/boxr/blob/master/spec/boxr/files_spec.rb#L106. Any chance you could add that in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Box API supports passing in the ID of a file version to copy. We have a need to ensure that if a file is being copied, the original (first) version is the one that is copied, no matter how many versions of the original there may be.
I used a kwarg because that's how
nameis handled, then added it to the attributes that are sent in the copy request only if an ID was provided.