Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github top banner is light when not logged in #1145

Closed
2 tasks done
500-internal-server-error opened this issue Jul 31, 2024 · 2 comments
Closed
2 tasks done

Github top banner is light when not logged in #1145

500-internal-server-error opened this issue Jul 31, 2024 · 2 comments
Labels
github GitHub

Comments

@500-internal-server-error

Is there an existing issue outlining your problem?

  • I am using the latest version of the provided userstyle.
  • I have searched the existing issues and they do not solve my problem.

What userstyles are you seeing the problem on?

lbl:github

Describe your problem.

The top bar is bright when not logged in, which probably looks fine on light mode but is a rather distracting flashbang due to the contrast otherwise.

Attach screenshots.

When logged in all dark and fine:
image
When not logged in I get flashbanged:
image

What browser(s) are you seeing the problem on?

Firefox v128.0.3

Any additional comments?

Maybe this is how the theme has always looked, but as a new user I find it to be quite an odd choice given the painful spike in contrast relative to the rest of the easy-on-the-eyes theme.

Perhaps it isn't intended to be that way, given the default github theme doesn't have this contrast spike on their dark mode?

@github-actions github-actions bot added the github GitHub label Jul 31, 2024
@uncenter
Copy link
Member

This is an issue with GitHub's HTML, where they explicitly set the theme to be light mode in that section of the page but invert it or something on their end:
CleanShot 2024-07-31 at 12 34 06@2x
It is properly themed with Latte though so I have no plans of changing this.

@uncenter uncenter closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
@uncenter
Copy link
Member

(Duplicate of #954 as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github GitHub
Projects
None yet
Development

No branches or pull requests

2 participants