unclear tip

[sineptic]

Is there an existing issue outlining your problem?

• I have searched the existing issues and they do not solve my problem.

Describe your issue.

How do I theme images and SVGs? don't clarify, that it don't work if you don't add any generic in svg, but almost all(I think) do this as first step.

[uncenter]

it don't work if you don't add any generic in svg

Please clarify, I don't know what you mean by this.

[sineptic]

don't work:

.some {
  @svg: escape('<svg fill="blue" width="300" height="130" xmlns="http://www.w3.org/2000/svg"><rect width="200" height="100" x="10" y="10" rx="20" ry="20"/></svg>');
  background-image: url("data:image/svg+xml,@{svg}");
}

work:

.some {
  @svg: escape('<svg fill="@{mauve}" width="300" height="130" xmlns="http://www.w3.org/2000/svg"><rect width="200" height="100" x="10" y="10" rx="20" ry="20"/></svg>');
  background-image: url("data:image/svg+xml,@{svg}");
}

[uncenter]

Yep. That's an issue with Stylus/Less really, but since the whole point of adding the SVG is changing the colors... that shouldn't be an issue. Feel free to open a PR explaining this if you want.

[sineptic]

Yes, "whole point of adding the SVG is changing the colors", but first step is just add it somehow. And for new users of Stylus(like me) this error is stange, because I follow docs.

[uncenter]

Right, but this isn't an issue with our instructions it's an issue with the parser. As I said feel free to raise a PR clarifying if you want to.

[sineptic]

did I need to make branch in fork for this pull request?

[uncenter]

did I need to make branch in fork for this pull request?

It helps to make it on a separate branch but technically you can make it from the main branch.