Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use a more compact multiaddress format over wire messages? #1270

Open
Xela101 opened this issue Jun 3, 2020 · 0 comments
Open
Labels
Enhancement 👷 New feature or request Question ❓ Further information is requested

Comments

@Xela101
Copy link

Xela101 commented Jun 3, 2020

Current protobuf wire MultiAddress format is:
/ip4/77.68.110.78/tcp/4001/ipfs/18n3naE9kBZoVvgYMV6saMZe3GsQiDaWiuhi4ngsz4yYghzBZanWyrCCxbg3QWZmWCK3

We can use a more optimized structure such as:
{
ip, bytes
port, bytes
peerId, bytes
}

and reconstruct on the backend.

@Xela101 Xela101 added the Enhancement 👷 New feature or request label Jun 3, 2020
@Xela101 Xela101 mentioned this issue Jun 3, 2020
11 tasks
@Xela101 Xela101 added the Question ❓ Further information is requested label Jun 3, 2020
@sudhirtibrewal sudhirtibrewal added this to the Full Consensus milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 👷 New feature or request Question ❓ Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants