-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring on the Anserini end to enable cleaner Pyserini bindings #2584
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2584 +/- ##
============================================
- Coverage 67.18% 67.17% -0.02%
+ Complexity 1480 1479 -1
============================================
Files 219 219
Lines 12700 12700
Branches 1530 1530
============================================
- Hits 8533 8531 -2
- Misses 3640 3641 +1
- Partials 527 528 +1 ☔ View full report in Codecov by Sentry. |
@MXueguang this is ready for review. The code coverage check is pointing at lines that are difficult to test, so I'm going to punt on that now. Running regressions - all seems good so far. Will circle back and confirm but CR can proceed in parallel. |
… ONNX on BEIR (#1977) Takes advantage of API changes in: castorini/anserini#2584
batch_search
in dense searchers - changed method signature to take queries, then qids - to be consistent withSimpleSearcher
andSimpleImpactSearcher
ThreadPoolExecutor
to use try-with-resources, see Refactor ThreadPoolExecutor to use try-with-resources #2579