Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in regressions involving dense vectors using flat indexes #2563

Closed
wants to merge 2 commits into from

Conversation

lintool
Copy link
Member

@lintool lintool commented Aug 6, 2024

(1) fix incorrect root commands of regressions involving flat indexes
(2) fix incorrect regression scores (in some cases)

@lintool lintool marked this pull request as draft August 6, 2024 00:35
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (b467d4a) to head (097e31f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2563   +/-   ##
=========================================
  Coverage     67.07%   67.07%           
  Complexity     1481     1481           
=========================================
  Files           219      219           
  Lines         12670    12670           
  Branches       1530     1530           
=========================================
  Hits           8499     8499           
  Misses         3644     3644           
  Partials        527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool
Copy link
Member Author

lintool commented Aug 7, 2024

Recently, I discovered that flat.onnx scores weren't accurately captured in the YAML regressions. This, in fact, was by design. All conditions captured the score of flat.cached, and I used score tolerances to account for divergences from this "reference". This simplified record keeping in the regressions.

Closing issue.

@lintool lintool closed this Aug 7, 2024
@lintool lintool deleted the score-tweaks branch August 7, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant