documentation update for splade++ huggingface -> onnx #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cadurosar can you please take a look at this? |
carlos-lassance
suggested changes
Aug 1, 2024
docs/onnx-conversion.md
Outdated
|
|
||
| --- | ||
|
|
||
| Another important component is being able to specify the dimensions of the input and output tensors. This is achieved by the following code: |
There was a problem hiding this comment.
I would say more that we are giving the dynamic axis names here and not specifying the dimensions
| cd src/main/python/onnx | ||
| # Now run the script | ||
| python3 run_onnx_model_inference.py --model_path models/splade-cocondenser-ensembledistil-optimized.onnx \ | ||
| --model_name naver/splade-cocondenser-ensembledistil |
There was a problem hiding this comment.
maybe an explanation here that we get the model nome to use the tokenizer?
Another possibility is using the model name to load the hf version and then do a comparison between both to check that things are ok (always reassuring to someone using this for the first time)
There was a problem hiding this comment.
Sounds good. I can add more details for this
|
@AndreSlavescu Can you also add a blurb on how to test the newly generated SPLADE++ ED model e2e? E.g., point to the repro, "swap in" the new model in |
lintool
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation for up to date e2e splade conversion to onnx (huggingface -> onnx)